Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date validation #2436

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

Raviramnani1
Copy link
Collaborator

Description

date validation for evently app

Closes: #XXXX

detail screen is modified
to check if the end date is not before start date


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

demo
date validation feature for event creation
@Raviramnani1 Raviramnani1 changed the base branch from main to feat/implementEvently June 21, 2024 14:27
@MikeSofaer
Copy link
Collaborator

I am still confused about build.gradle and what's wrong with it? And why change it in this PR?

@Raviramnani1
Copy link
Collaborator Author

I am still confused about build.gradle and what's wrong with it? And why change it in this PR?

without changing build config i was not able to run the app

@Raviramnani1
Copy link
Collaborator Author

Raviramnani1 commented Jun 21, 2024

I am still confused about build.gradle and what's wrong with it? And why change it in this PR?

maybe i should keep this config as it allows to run in my system and push the date validation

Copy link
Collaborator Author

@Raviramnani1 Raviramnani1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted back

@MikeSofaer MikeSofaer merged commit 8155e76 into Pylons-tech:feat/implementEvently Jun 21, 2024
16 of 19 checks passed
@zube zube bot removed the [zube]: Done label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants